Page 1 of 1

Javascript enabled

Posted: 19 Jul 2011, 12:12
by dollknoll
Hello,

If someone visit my website, without javascript in browser enabled, he see a landing page with following text:
[…]Oops! - This page requires Flash Player and Javascript[…]

But this don't work in the actual version 2.7.5.1 (the browser window remains empty).
The problem starts with the update from 2.7.2 to 2.7.3.

I fix this problem in the actual "index.gallery.phtml"-template.
I change line 116 from <div id="hud"> to <div>.
Now it works.


But I don't know if this is the right way... :?

Re: Javascript enabled

Posted: 19 Jul 2011, 17:28
by mjau-mjau
We did have a mistake leaving empty <table></table> in a previous release, but I haven't seen any pages where it does not work. Do you have an example?

Re: Javascript enabled

Posted: 20 Jul 2011, 02:30
by dollknoll
Yes I have an example.
Try this:
https://www.photo.gallery/demo/x2/



I test it with deactivated Javascript in Browser

MacOSX 10.6.8
Safari 5.0.5
Firefox 5.0.1
Opera 11.11

Re: Javascript enabled

Posted: 20 Jul 2011, 03:12
by dollknoll
In the actual "index.gallery.phtml"-template I found only two "table"-tags.
See screenshot.

Re: Javascript enabled

Posted: 21 Jul 2011, 04:46
by mjau-mjau
Actually, we did make some changes recently because we didn't find this "oops" text very useful. It was mainly for the early days to detect systems without flash and then display that message. However, now that the gallery is auto-redirecting all non-flash to the html and/or mobile version, the it does not have much use ... Right now it would only display strictly if the browser does not have javascript, and I don't think this is normal any longer ...

You do have a point though, and as a fallback, it should be displaying that text when javascript is not enabled. I will look into it ...

Re: Javascript enabled

Posted: 23 Jul 2011, 17:50
by dollknoll
Thanks for your help!

Re: Javascript enabled

Posted: 24 Jul 2011, 04:47
by mjau-mjau
This is fixed now ...